Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: runtime/vm/class_finalizer.h

Issue 13653005: Prevent expensive and unnecessary error formatting in the case a bound check is (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_CLASS_FINALIZER_H_ 5 #ifndef VM_CLASS_FINALIZER_H_
6 #define VM_CLASS_FINALIZER_H_ 6 #define VM_CLASS_FINALIZER_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/growable_array.h" 9 #include "vm/growable_array.h"
10 10
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 static void FinalizeTypeArguments(const Class& cls, 113 static void FinalizeTypeArguments(const Class& cls,
114 const AbstractTypeArguments& arguments, 114 const AbstractTypeArguments& arguments,
115 FinalizationKind finalization, 115 FinalizationKind finalization,
116 Error* bound_error); 116 Error* bound_error);
117 static void CheckTypeArgumentBounds(const Class& cls, 117 static void CheckTypeArgumentBounds(const Class& cls,
118 const AbstractTypeArguments& arguments, 118 const AbstractTypeArguments& arguments,
119 Error* bound_error); 119 Error* bound_error);
120 static void ResolveType(const Class& cls, 120 static void ResolveType(const Class& cls,
121 const AbstractType& type, 121 const AbstractType& type,
122 FinalizationKind finalization); 122 FinalizationKind finalization);
123 static void ResolveAndFinalizeUpperBounds(const Class& cls); 123 static void ResolveUpperBounds(const Class& cls);
124 static void FinalizeUpperBounds(const Class& cls);
124 static void ResolveAndFinalizeSignature(const Class& cls, 125 static void ResolveAndFinalizeSignature(const Class& cls,
125 const Function& function); 126 const Function& function);
126 static void ResolveAndFinalizeMemberTypes(const Class& cls); 127 static void ResolveAndFinalizeMemberTypes(const Class& cls);
127 static void PrintClassInformation(const Class& cls); 128 static void PrintClassInformation(const Class& cls);
128 static void CollectInterfaces(const Class& cls, 129 static void CollectInterfaces(const Class& cls,
129 const GrowableObjectArray& interfaces); 130 const GrowableObjectArray& interfaces);
130 static void ReportMalformedType(const Error& prev_error, 131 static void ReportMalformedType(const Error& prev_error,
131 const Class& cls, 132 const Class& cls,
132 const Type& type, 133 const Type& type,
133 FinalizationKind finalization, 134 FinalizationKind finalization,
134 const char* format, 135 const char* format,
135 va_list args); 136 va_list args);
136 static void ReportError(const Error& error); 137 static void ReportError(const Error& error);
137 static void ReportError(const Script& script, 138 static void ReportError(const Script& script,
138 intptr_t token_index, 139 intptr_t token_index,
139 const char* format, ...) PRINTF_ATTRIBUTE(3, 4); 140 const char* format, ...) PRINTF_ATTRIBUTE(3, 4);
140 static void ReportError(const char* format, ...) PRINTF_ATTRIBUTE(1, 2); 141 static void ReportError(const char* format, ...) PRINTF_ATTRIBUTE(1, 2);
141 }; 142 };
142 143
143 } // namespace dart 144 } // namespace dart
144 145
145 #endif // VM_CLASS_FINALIZER_H_ 146 #endif // VM_CLASS_FINALIZER_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698