Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1365293002: [test] Copy test262-es6 into test262. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, adamk, Dan Ehrenberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Copy test262-es6 into test262. BUG=v8:4254 LOG=n NOTRY=true Committed: https://crrev.com/c9acb6614bd4347061b7f6bc3dd3dfd663d40e99 Cr-Commit-Position: refs/heads/master@{#30936}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+797 lines, -322 lines) Patch
M test/test262/README View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test262/harness-adapt.js View 1 chunk +9 lines, -0 lines 0 comments Download
M test/test262/test262.status View 3 chunks +676 lines, -308 lines 0 comments Download
M test/test262/testcfg.py View 1 3 chunks +110 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Michael Achenbach
PTAL. 1:1 copy of everything from the test262-es6 folder. Only changed the status file name.
5 years, 2 months ago (2015-09-25 12:40:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365293002/1
5 years, 2 months ago (2015-09-25 12:41:11 UTC) #4
Jakob Kummerow
Rubberstamp LGTM. How about dropping the test262-es6 directory? https://codereview.chromium.org/1365293002/diff/1/test/test262/testcfg.py File test/test262/testcfg.py (right): https://codereview.chromium.org/1365293002/diff/1/test/test262/testcfg.py#newcode34 test/test262/testcfg.py:34: import ...
5 years, 2 months ago (2015-09-25 12:48:30 UTC) #5
Michael Achenbach
https://codereview.chromium.org/1365293002/diff/1/test/test262/testcfg.py File test/test262/testcfg.py (right): https://codereview.chromium.org/1365293002/diff/1/test/test262/testcfg.py#newcode34 test/test262/testcfg.py:34: import imp On 2015/09/25 12:48:30, Jakob wrote: > nit: ...
5 years, 2 months ago (2015-09-25 12:51:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365293002/20001
5 years, 2 months ago (2015-09-25 12:52:18 UTC) #9
Michael Achenbach
Changed CL description. This is copy-only. Removal comes after removal on buildbot.
5 years, 2 months ago (2015-09-25 12:52:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 13:03:31 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 13:03:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9acb6614bd4347061b7f6bc3dd3dfd663d40e99
Cr-Commit-Position: refs/heads/master@{#30936}

Powered by Google App Engine
This is Rietveld 408576698