Issue 1365253003: Merge to XFA: Fix the issue that pdfium swallows 'fi' or 'ff' in some pdf files

Issue 1365253003: Merge to XFA: Fix the issue that pdfium swallows 'fi' or 'ff' in some pdf files (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
jun_fang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Fix the issue that pdfium swallows 'fi' or 'ff' in some pdf files Pdfium swallows 'fi' or 'ff' in some tested files because it doesn't load the embedded font file correctly. The root cause is that there is incorrect keyword like 'ngendstream' in the stream of the embedded font file. Pdfium tries to find another correct keyword but uses wrong offset rather than accumulated offset. BUG=524043 TBR=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1307353005 . (cherry picked from commit 9bd18183ba8210c91d71c3060146235750a4c71c) Committed: https://pdfium.googlesource.com/pdfium/+/37890560caa14fc54b237bb4928a4e843cc635b8

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -97 lines)			Patch
M	core/include/fpdfapi/fpdf_parser.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp	View	3 chunks	+2 lines, -32 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/pageint.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	10 chunks	+23 lines, -33 lines	0 comments	Download
A +	testing/resources/pixel/bug_524043_1.in	View	1 chunk	+8 lines, -3 lines	0 comments	Download
A	testing/resources/pixel/bug_524043_1_expected.pdf.0.png	View	Binary file		0 comments	Download
A +	testing/resources/pixel/bug_524043_2.in	View	1 chunk	+9 lines, -3 lines	0 comments	Download
A	testing/resources/pixel/bug_524043_2_expected.pdf.0.png	View	Binary file		0 comments	Download
A +	testing/resources/pixel/bug_524043_3.in	View	1 chunk	+9 lines, -3 lines	0 comments	Download
A	testing/resources/pixel/bug_524043_3_expected.pdf.0.png	View	Binary file		0 comments	Download
A +	testing/resources/pixel/bug_524043_4.in	View	1 chunk	+9 lines, -4 lines	0 comments	Download
A	testing/resources/pixel/bug_524043_4_expected.pdf.0.png	View	Binary file		0 comments	Download
A +	testing/resources/pixel/bug_524043_5.in	View	1 chunk	+9 lines, -4 lines	0 comments	Download
A	testing/resources/pixel/bug_524043_5_expected.pdf.0.png	View	Binary file		0 comments	Download
A +	testing/resources/pixel/bug_524043_6.in	View	1 chunk	+9 lines, -5 lines	0 comments	Download
A	testing/resources/pixel/bug_524043_6_expected.pdf.0.png	View	Binary file		0 comments	Download
A +	testing/resources/pixel/bug_524043_7.in	View	1 chunk	+10 lines, -5 lines	0 comments	Download
A	testing/resources/pixel/bug_524043_7_expected.pdf.0.png	View	Binary file		0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

5 years, 2 months ago (2015-09-26 05:51:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
37890560caa14fc54b237bb4928a4e843cc635b8 (presubmit successful).

Expand Messages | Collapse Messages