Issue 136523005: Use the right priority when marking QUIC streams write blocked via

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136523005: Use the right priority when marking QUIC streams write blocked via (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)

Modified:
6 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use the right priority when marking QUIC streams write blocked via QuicFdWrapper::SetReady. Not flag protected. Merge internal change: 59263642 R=rch@chromium.org

Patch Set 2 : Use NULL instead of nullptr #

Patch Set 3 : fixes for quic_reliable_client_stream_test #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -23 lines)			Patch
M	net/quic/quic_reliable_client_stream_test.cc	View	1 2	6 chunks	+26 lines, -21 lines	0 comments	Download
M	net/quic/quic_session.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	net/quic/quic_session_test.cc	View		3 chunks	+29 lines, -2 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/136523005/diff/1/net/quic/quic_session.cc File net/quic/quic_session.cc (right): https://codereview.chromium.org/136523005/diff/1/net/quic/quic_session.cc#newcode593 net/quic/quic_session.cc:593: if (stream != nullptr) { I don't think ...

6 years, 11 months ago (2014-01-14 00:39:58 UTC) #2

ramant (doing other things)

6 years, 11 months ago (2014-01-14 07:49:01 UTC) #3

https://codereview.chromium.org/136523005/diff/1/net/quic/quic_session.cc
File net/quic/quic_session.cc (right):

https://codereview.chromium.org/136523005/diff/1/net/quic/quic_session.cc#new...
net/quic/quic_session.cc:593: if (stream != nullptr) {
On 2014/01/14 00:39:58, Ryan Hamilton wrote:
> I don't think we have nullptr yet.  (This is my fault for not noticing this in
> the internal review)

Sorry to have missed it.

Done.