Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: public/platform/WebSourceBuffer.h

Issue 136523004: Add PARSING_MEDIA_SEGMENT layout test for SourceBuffer mode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebSourceBuffer.h
diff --git a/public/platform/WebSourceBuffer.h b/public/platform/WebSourceBuffer.h
index b8960df909d5a4444d35ee619d043ded6b410aab..e789648be8f95d62073d2a76d7bdaf74fbe6a0c4 100644
--- a/public/platform/WebSourceBuffer.h
+++ b/public/platform/WebSourceBuffer.h
@@ -43,10 +43,7 @@ public:
};
virtual ~WebSourceBuffer() { }
-
- // FIXME: Remove default implementation once Chromium setMode() implementation has landed. See http://crbug.com/249422.
- virtual bool setMode(AppendMode) { return true; }
-
+ virtual bool setMode(AppendMode) = 0;
virtual WebTimeRanges buffered() = 0;
virtual void append(const unsigned char* data, unsigned length) = 0;
virtual void abort() = 0;
« no previous file with comments | « LayoutTests/http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698