public/platform/WebSourceBuffer.h - Issue 136523004: Add PARSING_MEDIA_SEGMENT layout test for SourceBuffer mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebSourceBuffer.h

Issue 136523004: Add PARSING_MEDIA_SEGMENT layout test for SourceBuffer mode (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: public/platform/WebSourceBuffer.h

diff --git a/public/platform/WebSourceBuffer.h b/public/platform/WebSourceBuffer.h

index b8960df909d5a4444d35ee619d043ded6b410aab..e789648be8f95d62073d2a76d7bdaf74fbe6a0c4 100644

--- a/public/platform/WebSourceBuffer.h

+++ b/public/platform/WebSourceBuffer.h

@@ -43,10 +43,7 @@ public:

};

virtual ~WebSourceBuffer() { }

- // FIXME: Remove default implementation once Chromium setMode() implementation has landed. See http://crbug.com/249422.

- virtual bool setMode(AppendMode) { return true; }

+ virtual bool setMode(AppendMode) = 0;

virtual WebTimeRanges buffered() = 0;

virtual void append(const unsigned char* data, unsigned length) = 0;

virtual void abort() = 0;