Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1365203002: Make WebNode::to<Type>() (and toConst) casts contain type asserts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add BLINK_IMPLEMENTATION guard. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 3fceeb2c2a45b9bcaf9f9a6971591191a5e34827..228996e93fc80f3cb8fd10e19484bc1180d0ac76 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -5345,7 +5345,6 @@ TEST_P(ParameterizedWebFrameTest, SlowSpellcheckMarkerPosition)
webViewHelper.webView()->setSpellCheckClient(&spellcheck);
WebLocalFrameImpl* frame = toWebLocalFrameImpl(webViewHelper.webView()->mainFrame());
- WebInputElement webInputElement = frame->document().getElementById("data").to<WebInputElement>();
Document* document = frame->frame()->document();
Element* element = document->getElementById("data");
@@ -5357,7 +5356,6 @@ TEST_P(ParameterizedWebFrameTest, SlowSpellcheckMarkerPosition)
NonThrowableExceptionState exceptionState;
document->execCommand("InsertText", false, "wellcome ", exceptionState);
EXPECT_FALSE(exceptionState.hadException());
- webInputElement.setSelectionRange(0, 0);
document->execCommand("InsertText", false, "he", exceptionState);
EXPECT_FALSE(exceptionState.hadException());
@@ -5400,7 +5398,6 @@ TEST_P(ParameterizedWebFrameTest, SpellcheckResultErasesMarkers)
webViewHelper.webView()->setSpellCheckClient(&spellcheck);
WebLocalFrameImpl* frame = toWebLocalFrameImpl(webViewHelper.webView()->mainFrame());
- WebInputElement webInputElement = frame->document().getElementById("data").to<WebInputElement>();
Document* document = frame->frame()->document();
Element* element = document->getElementById("data");
@@ -5432,7 +5429,6 @@ TEST_P(ParameterizedWebFrameTest, SpellcheckResultsSavedInDocument)
webViewHelper.webView()->setSpellCheckClient(&spellcheck);
WebLocalFrameImpl* frame = toWebLocalFrameImpl(webViewHelper.webView()->mainFrame());
- WebInputElement webInputElement = frame->document().getElementById("data").to<WebInputElement>();
Document* document = frame->frame()->document();
Element* element = document->getElementById("data");
« no previous file with comments | « third_party/WebKit/Source/web/WebTextAreaElement.cpp ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698