Make WebNode::to<Type>() (and toConst) casts contain type asserts.

chrome/renderer/autofill/form_autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/strings/string16.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 1001 matching lines @@
     std::vector<FormData> forms = form_cache.ExtractNewForms();
     ASSERT_EQ(1U, forms.size());
 
     // Set the auto-filled attribute.
     WebInputElement firstname = GetInputElementById("firstname");
     firstname.setAutofilled(true);
     WebInputElement lastname = GetInputElementById("lastname");
     lastname.setAutofilled(true);
     WebInputElement month = GetInputElementById("month");
     month.setAutofilled(true);
-    WebInputElement textarea = GetInputElementById("textarea");
+    WebFormControlElement textarea = GetFormControlElementById("textarea");
     textarea.setAutofilled(true);
 
     // Set the value of the disabled text input element.
     WebInputElement notenabled = GetInputElementById("notenabled");
     notenabled.setValue(WebString::fromUTF8("no clear"));
 
     // Clear the form.
     EXPECT_TRUE(form_cache.ClearFormWithElement(firstname));
 
     // Verify that the auto-filled attribute has been turned off.
@@ skipping 963 matching lines @@
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[4]);
 
   expected.name = ASCIIToUTF16("month");
   expected.value = ASCIIToUTF16("2011-12");
   expected.label = ASCIIToUTF16("Card expiration:");
   expected.form_control_type = "month";
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[5]);
 }
 
+TEST_F(FormAutofillTest, WebFormElementConsiderNonControlLabelableElements) {
+  LoadHTML("<form id=form>"
+           "  <label for='progress'>Progress:</label>"
+           "  <progress id='progress'></progress>"
+           "  <label for='firstname'>First name:</label>"
+           "  <input type='text' id='firstname' value='John'>"
+           "</form>");
+
+  WebFrame* frame = GetMainFrame();
+  ASSERT_NE(nullptr, frame);
+
+  WebFormElement web_form = frame->document().getElementById("form")
+      .to<WebFormElement>();
+  ASSERT_FALSE(web_form.isNull());
+
+  FormData form;
+  EXPECT_TRUE(WebFormElementToFormData(web_form, WebFormControlElement(),
+                                       EXTRACT_NONE, &form, nullptr));
+
+  const std::vector<FormFieldData>& fields = form.fields;
+  ASSERT_EQ(1U, fields.size());
+  EXPECT_EQ(ASCIIToUTF16("firstname"), fields[0].name);
+}
+
 // We should not be able to serialize a form with too many fillable fields.
 TEST_F(FormAutofillTest, WebFormElementToFormDataTooManyFields) {
   std::string html =
       "<FORM name='TestForm' action='http://cnn.com' method='post'>";
   for (size_t i = 0; i < (kMaxParseableFields + 1); ++i) {
     html += "<INPUT type='text'/>";
   }
   html += "</FORM>";
   LoadHTML(html.c_str());
 
@@ skipping 2082 matching lines @@
   ASSERT_TRUE(control_elements.empty());
   ASSERT_TRUE(fieldsets.empty());
 
   FormData form;
   EXPECT_FALSE(UnownedCheckoutFormElementsAndFieldSetsToFormData(
       fieldsets, control_elements, nullptr, frame->document(), extract_mask,
       &form, nullptr));
 }
 
 }  // namespace autofill