Chromium Code Reviews| Index: build/download_nacl_toolchains.py |
| diff --git a/build/download_nacl_toolchains.py b/build/download_nacl_toolchains.py |
| index c2007d0f1038258af358413cf8a06e8e210445f7..159d906c3d9d6cddb1d432a29e2ef84ab3205bde 100755 |
| --- a/build/download_nacl_toolchains.py |
| +++ b/build/download_nacl_toolchains.py |
| @@ -34,22 +34,21 @@ def Main(args): |
| # gclient sync time for developers, or standard Chrome bots. |
| if '--optional-pnacl' in args: |
| args.remove('--optional-pnacl') |
| - # By default we don't use PNaCl toolchain yet, unless on ARM, where |
| - # there is no other toolchain to build untrusted code at the moment. |
| - # So analyze if we're building for ARM, or on SDK buildbot. |
| - # TODO(olonho): we need to invent more reliable way to get build |
| - # configuration info, to know if we're building for ARM. |
| use_pnacl = False |
| - if 'target_arch=arm' in os.environ.get('GYP_DEFINES', ''): |
| - use_pnacl = True |
| buildbot_name = os.environ.get('BUILDBOT_BUILDERNAME', '') |
| - if buildbot_name.find('pnacl') >= 0 and buildbot_name.find('sdk') >= 0: |
| + if 'pnacl' in buildbot_name and 'sdk' in buildbot_name: |
| use_pnacl = True |
| if use_pnacl: |
| print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n' |
| else: |
| args.append('--no-pnacl') |
| + # Only download the ARM gcc toolchain if we are building for ARM |
| + # TODO(olonho): we need to invent more reliable way to get build |
| + # configuration info, to know if we're building for ARM. |
| + if 'target_arch=arm' in os.environ.get('GYP_DEFINES', ''): |
| + args.append('--arm-untrusted') |
| + |
| # Append the name of the file to use as a version and hash source. |
| # NOTE: While not recommended, it is possible to redirect this file to |
| # a chrome location to avoid branching NaCl if just a toolchain needs |
| @@ -62,3 +61,4 @@ def Main(args): |
| if __name__ == '__main__': |
| sys.exit(Main(sys.argv[1:])) |
| + sys.exit(Main(sys.argv[1:])) |
|
Derek Schuff
2013/04/04 20:36:55
duplicate?
|