Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1365173005: [Chromecast] Move audio logging from PushFrame to Start. (Closed)

Created:
5 years, 2 months ago by mbjorge
Modified:
5 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, gunsch+watch_chromium.org, halliwell+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Move audio logging from PushFrame to Start. Putting logging in CastAudioOutputStream::PushFrame was generating many unnecessary tasks. Moving the logging call to Start() greatly reduces the number of posted tasks and still records the metric properly. BUG=internal b/23214538 Committed: https://crrev.com/7936d0c4cc3886613a86643aaf411e31a89d0b24 Cr-Commit-Position: refs/heads/master@{#350867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromecast/media/audio/cast_audio_output_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mbjorge
5 years, 2 months ago (2015-09-25 17:34:19 UTC) #2
halliwell
On 2015/09/25 17:34:19, mbjorge wrote: lgtm, send me that bug as well :)
5 years, 2 months ago (2015-09-25 17:35:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365173005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365173005/1
5 years, 2 months ago (2015-09-25 17:55:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 18:20:18 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 18:21:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7936d0c4cc3886613a86643aaf411e31a89d0b24
Cr-Commit-Position: refs/heads/master@{#350867}

Powered by Google App Engine
This is Rietveld 408576698