Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1365113003: Fix a sign-compare error to make gcc 4.9.2 happy. (Closed)

Created:
5 years, 2 months ago by paul.l...
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix a sign-compare error to make gcc 4.9.2 happy. This is from https://chromium.googlesource.com/v8/v8/+/347fa90626a448e3535cf6aa100124dfd5b711ce BUG= Committed: https://crrev.com/145a2f45f3379029d6255a073e3eb762549ea47e Cr-Commit-Position: refs/heads/master@{#30932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/interpreter/bytecode-array-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365113003/1
5 years, 2 months ago (2015-09-25 01:27:23 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-25 01:55:10 UTC) #4
paul.l...
PTAL. If it looks OK, please commit it, as I won't be back online for ...
5 years, 2 months ago (2015-09-25 01:57:35 UTC) #6
oth
On 2015/09/25 01:57:35, paul.l... wrote: > PTAL. If it looks OK, please commit it, as ...
5 years, 2 months ago (2015-09-25 08:59:01 UTC) #7
rmcilroy
LGTM.
5 years, 2 months ago (2015-09-25 10:36:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365113003/1
5 years, 2 months ago (2015-09-25 10:49:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 11:31:40 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 11:31:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/145a2f45f3379029d6255a073e3eb762549ea47e
Cr-Commit-Position: refs/heads/master@{#30932}

Powered by Google App Engine
This is Rietveld 408576698