Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: build/java_apk.gypi

Issue 13651003: Package correct libraries in apk (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/ant/apk-package.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index 1e797f15c1c8a4daf07205f7b1e7499771a3fb39..e6fdc2e009149ff528fbdcda780b4f32e507c39f 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -102,6 +102,7 @@
'codegen_input_paths': [],
'final_apk_path': '<(PRODUCT_DIR)/apks/<(apk_name).apk',
'apk_install_stamp': '<(intermediate_dir)/apk_install.stamp',
+ 'apk_package_native_libs_dir': '<(intermediate_dir)/libs',
},
# Pass the jar path to the apk's "fake" jar target. This would be better as
# direct_dependent_settings, but a variable set by a direct_dependent_settings
@@ -218,7 +219,8 @@
'conditions': [
['gyp_managed_install == 1', {
'variables': {
- 'apk_libraries_dir': '<(intermediate_dir)/lib.stripped/',
+ 'apk_libraries_dir': '<(intermediate_dir)/lib.stripped/<(android_app_abi)',
+ 'apk_package_native_libs_dir': '<(intermediate_dir)/libs.managed',
'device_library_dir': '/data/local/tmp/chromium/lib.stripped/<(_target_name)',
},
'dependencies': [
@@ -267,7 +269,7 @@
],
}, {
Yaron 2013/04/04 20:31:47 Nit: Add # gyp_managed_install != 1
cjhopman 2013/04/05 16:46:20 Done.
'variables': {
- 'apk_libraries_dir': '<(intermediate_dir)/libs/<(android_app_abi)',
+ 'apk_libraries_dir': '<(apk_package_native_libs_dir)/<(android_app_abi)',
'package_input_paths': [ '<(strip_stamp)' ],
},
}],
@@ -552,6 +554,7 @@
'-DASSET_DIR=<(asset_location)',
'-DCONFIGURATION_NAME=<(CONFIGURATION_NAME)',
'-DKEYSTORE_PATH=<(DEPTH)/build/android/ant/chromium-debug.keystore',
+ '-DNATIVE_LIBS_DIR=<(apk_package_native_libs_dir)',
'-DOUT_DIR=<(intermediate_dir)',
'-DRESOURCE_DIR=<(resource_dir)',
'-DSOURCE_DIR=<(java_in_dir)/src',
« no previous file with comments | « build/android/ant/apk-package.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698