Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 1365003002: Oilpan: exempt CSSBasicShapeValue from GC plugin checking. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: exempt CSSBasicShapeValue from GC plugin checking. The GC plugin isn't capable of determining that CSSValue's traceAfterDispatch() method is safe for subtypes of CSSBasicShapeValue and throws an error. Until the plugin or the method have been adjusted into a form that passes the plugin's static checks, exempt the class from the GC plugin's reach. R=haraken BUG=535448 Committed: https://crrev.com/ede2b736857fdb9665a685a690f092477a27b9dd Cr-Commit-Position: refs/heads/master@{#350508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/CSSBasicShapeValue.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look. (It's a new world, looks like the default Cc:s didn't carry ...
5 years, 3 months ago (2015-09-24 07:48:05 UTC) #2
haraken
LGTM as a short-term fix.
5 years, 3 months ago (2015-09-24 07:51:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365003002/1
5 years, 3 months ago (2015-09-24 07:53:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 08:47:50 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 08:48:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ede2b736857fdb9665a685a690f092477a27b9dd
Cr-Commit-Position: refs/heads/master@{#350508}

Powered by Google App Engine
This is Rietveld 408576698