Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13650009: Remove Dashboard support and supporting files. (Closed)

Created:
7 years, 8 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 8 months ago
CC:
blink-reviews, Alexis Menard
Visibility:
Public.

Description

Remove Dashboard support and supporting files. R=abarth,eseidel,eae BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147538

Patch Set 1 #

Patch Set 2 : Fix compiler error due to misspelling in code "Dashbard" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -788 lines) Patch
M Source/WTF/wtf/FeatureDefines.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/WebCore.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/css/CSSComputedStyleDeclaration.cpp View 3 chunks +0 lines, -39 lines 0 comments Download
M Source/WebCore/css/CSSParser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/css/CSSParser.cpp View 3 chunks +0 lines, -151 lines 0 comments Download
M Source/WebCore/css/CSSParserValues.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/css/CSSPrimitiveValue.h View 5 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/css/CSSPrimitiveValue.cpp View 8 chunks +0 lines, -77 lines 0 comments Download
M Source/WebCore/css/CSSProperty.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/css/CSSPropertyNames.in View 1 chunk +0 lines, -3 lines 0 comments Download
D Source/WebCore/css/DashboardRegion.h View 1 chunk +0 lines, -54 lines 0 comments Download
M Source/WebCore/css/StyleResolver.cpp View 2 chunks +0 lines, -48 lines 0 comments Download
M Source/WebCore/dom/Document.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/dom/make_names.pl View 2 chunks +1 line, -13 lines 0 comments Download
M Source/WebCore/html/HTMLCanvasElement.cpp View 1 1 chunk +1 line, -6 lines 0 comments Download
M Source/WebCore/html/HTMLElement.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/WebCore/html/HTMLEmbedElement.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/WebCore/html/HTMLImageLoader.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/WebCore/html/canvas/CanvasGradient.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/WebCore/html/canvas/CanvasGradient.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/WebCore/html/canvas/CanvasRenderingContext2D.h View 5 chunks +3 lines, -12 lines 0 comments Download
M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp View 8 chunks +1 line, -39 lines 0 comments Download
M Source/WebCore/page/Chrome.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/page/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/page/FrameView.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/page/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/page/mac/EventHandlerMac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/WebCore/rendering/RenderInline.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/RenderInline.cpp View 3 chunks +2 lines, -39 lines 0 comments Download
M Source/WebCore/rendering/RenderLayer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/rendering/RenderListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/RenderObject.h View 3 chunks +2 lines, -12 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.cpp View 3 chunks +2 lines, -33 lines 0 comments Download
M Source/WebCore/rendering/style/RenderStyle.h View 3 chunks +0 lines, -27 lines 0 comments Download
M Source/WebCore/rendering/style/RenderStyle.cpp View 2 chunks +0 lines, -33 lines 0 comments Download
D Source/WebCore/rendering/style/StyleDashboardRegion.h View 1 chunk +0 lines, -61 lines 0 comments Download
M Source/WebCore/rendering/style/StyleRareNonInheritedData.h View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/xml/XMLHttpRequest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/xml/XMLHttpRequest.cpp View 5 chunks +4 lines, -29 lines 0 comments Download
M Source/WebKit/chromium/features.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
leviw_travelin_and_unemployed
7 years, 8 months ago (2013-04-04 21:32:08 UTC) #1
abarth-chromium
LGTM!
7 years, 8 months ago (2013-04-04 21:44:26 UTC) #2
abarth-chromium
We don't have great bot coverage at the moment, so this might create a hole ...
7 years, 8 months ago (2013-04-04 21:45:00 UTC) #3
leviw_travelin_and_unemployed
7 years, 8 months ago (2013-04-04 22:13:17 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r147538 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698