Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: gm/gm_error.h

Issue 13650002: gm: report ExpectationsMismatch and RenderModeMismatch results separately (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: add_kRenderModeMismatch_not_used_yet Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gm/gmmain.cpp » ('j') | gm/tests/outputs/pipe-playback-failure/output-expected/stdout » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/gm_error.h
===================================================================
--- gm/gm_error.h (revision 8534)
+++ gm/gm_error.h (working copy)
@@ -26,7 +26,8 @@
// or off (as long as the number of these errors is 0).
kNoGpuContext_ErrorType,
- kImageMismatch_ErrorType,
+ kRenderModeMismatch_ErrorType,
epoger 2013/04/04 16:55:57 patchset 3 adds a new kRenderModeMismatch_ErrorTyp
+ kExpectationsMismatch_ErrorType,
kMissingExpectations_ErrorType,
kWritingReferenceImage_ErrorType,
kLast_ErrorType = kWritingReferenceImage_ErrorType
@@ -39,8 +40,10 @@
switch(type) {
case kNoGpuContext_ErrorType:
return "NoGpuContext";
- case kImageMismatch_ErrorType:
- return "ImageMismatch";
+ case kRenderModeMismatch_ErrorType:
+ return "RenderModeMismatch";
+ case kExpectationsMismatch_ErrorType:
+ return "ExpectationsMismatch";
case kMissingExpectations_ErrorType:
return "MissingExpectations";
case kWritingReferenceImage_ErrorType:
« no previous file with comments | « no previous file | gm/gmmain.cpp » ('j') | gm/tests/outputs/pipe-playback-failure/output-expected/stdout » ('J')

Powered by Google App Engine
This is Rietveld 408576698