Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1364993003: Add FetchUtils::normalizeHeaderValue( ) (Closed)

Created:
5 years, 3 months ago by shiva.jm
Modified:
5 years, 2 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FetchUtils::normalizeHeaderValue( ) These api will be used to normalize the header values in Fetch and XHR module. Background information: This is splitted from [1], and will be used by [1] and [2]. [1] https://codereview.chromium.org/1288263003/ [2] https://codereview.chromium.org/1342443004/ BUG=455099 Committed: https://crrev.com/85ad52a02623aca6f70df1bfe156f9002930a518 Cr-Commit-Position: refs/heads/master@{#351053}

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchUtils.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchUtils.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp View 1 2 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (5 generated)
shiva.jm
pls have a look, these CL is merge from https://codereview.chromium.org/1341273002/. since after blink merge, we ...
5 years, 3 months ago (2015-09-24 08:51:15 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/1364993003/diff/1/third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp File third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp (right): https://codereview.chromium.org/1364993003/diff/1/third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp#newcode6 third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp:6: #define FetchUtilsTest_h oh, I didn't catch this. remove the ...
5 years, 3 months ago (2015-09-24 09:24:02 UTC) #3
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/1364993003/diff/1/third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp File third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp (right): https://codereview.chromium.org/1364993003/diff/1/third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp#newcode11 third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp:11: #include "wtf/text/AtomicString.h" is this necessary?
5 years, 3 months ago (2015-09-24 09:26:57 UTC) #4
shiva.jm
pls have a look, updated patch with comments. https://codereview.chromium.org/1364993003/diff/1/third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp File third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp (right): https://codereview.chromium.org/1364993003/diff/1/third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp#newcode6 third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp:6: #define ...
5 years, 3 months ago (2015-09-24 09:41:39 UTC) #5
shiva.jm
@Mike and Chapin, tests have passed in all bots, pls have look. These CL is ...
5 years, 2 months ago (2015-09-25 14:22:33 UTC) #6
shiva.jm
5 years, 2 months ago (2015-09-28 03:52:41 UTC) #8
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/1364993003/diff/1/third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp File third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp (right): https://codereview.chromium.org/1364993003/diff/1/third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp#newcode11 third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp:11: #include "wtf/text/AtomicString.h" On 2015/09/24 09:41:38, shiva.jm wrote: > ...
5 years, 2 months ago (2015-09-28 06:02:09 UTC) #9
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/1364993003/diff/1/third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp File third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp (right): https://codereview.chromium.org/1364993003/diff/1/third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp#newcode6 third_party/WebKit/Source/core/fetch/FetchUtilsTest.cpp:6: #define FetchUtilsTest_h On 2015/09/24 09:41:38, shiva.jm wrote: > On ...
5 years, 2 months ago (2015-09-28 06:03:37 UTC) #10
shiva.jm
updated the test file to use header wtf/text/WTFString.h, pls have a look.
5 years, 2 months ago (2015-09-28 08:22:28 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364993003/40001
5 years, 2 months ago (2015-09-28 08:23:03 UTC) #13
tyoshino (SeeGerritForStatus)
lgtm
5 years, 2 months ago (2015-09-28 08:23:08 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 09:43:16 UTC) #16
Mike West
LGTM.
5 years, 2 months ago (2015-09-28 10:58:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364993003/40001
5 years, 2 months ago (2015-09-28 10:59:14 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 11:04:08 UTC) #20
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 11:04:51 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/85ad52a02623aca6f70df1bfe156f9002930a518
Cr-Commit-Position: refs/heads/master@{#351053}

Powered by Google App Engine
This is Rietveld 408576698