.gitignore - Issue 1364983002: Add CIPD binary installation to DEPS runhooks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: .gitignore

Issue 1364983002: Add CIPD binary installation to DEPS runhooks. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Use "cipd_package_root/" instead of "bin/", better class grouping. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 *.pyc	1 *.pyc

2 .coverage	2 .coverage

3 .expect_tests_coverage*	3 .expect_tests_coverage*

4 ENV	4 ENV

5 .wheelcache	5 .wheelcache

6 luci	6 luci

7 appengine/swarming	7 appengine/swarming

8 appengine/milo/vulcanized_main.html	8 appengine/milo/vulcanized_main.html

9 appengine/experimental/milo-linear/vulcanized_main.html	9 appengine/experimental/milo-linear/vulcanized_main.html

10 appengine/milo/html/parts/graph/viz.js	10 appengine/milo/html/parts/graph/viz.js

	11 /cipd_package_root/
	Vadim Sh. 2015/09/25 18:26:35 just /cipd/ ? cipd_package_root is long.. note a just /cipd/ ? cipd_package_root is long.. note also that most of our infra/tools/* packages install in root directly, not in bin/. So /cipd will look a bit weird: /cipd/bin/protoc /cipd/include/... /cipd/cipd /cipd/authutil /cipd/cloudtail ... Maybe move protoc out of bin/? Perhaps by providing --exec-prefix or different --includedir to 'configure'? dnj* 2015/09/25 18:39:14 Okay. Show quoted text On 2015/09/25 18:26:35, Vadim Sh. wrote: > just /cipd/ ? > > cipd_package_root is long.. Okay. Show quoted text > note also that most of our infra/tools/* packages install in root directly, not > in bin/*. So /cipd will look a bit weird: > /cipd/bin/protoc > /cipd/include/... > /cipd/cipd > /cipd/authutil > /cipd/cloudtail > ... > > Maybe move protoc out of bin/? Perhaps by providing --exec-prefix or different > --includedir to 'configure'? The include directory searching is hard-coded into "protoc" logic :( It searches: - <binary>/include - <binary>/../include I could go with <binary>/include (so still stop-level), but I was trying to be somewhat forward-thinking in case other utilities needed similar system-level directories. Not sure if that's too important, though. WDYT?
11 .DS_Store	12 .DS_Store

12 /node/runtimes	13 /node/runtimes

13 # build_cache is used by infra.services.builder_alerts	14 # build_cache is used by infra.services.builder_alerts

14 build_cache	15 build_cache

15 go/src/github.com	16 go/src/github.com

16 recipes-py	17 recipes-py

OLD	NEW

« no previous file with comments | « no previous file | DEPS » ('j') | no next file with comments »