Update some more infobars to use vector icons.

Update some more infobars to use vector icons.

BUG=520266
Committed: https://crrev.com/512adb1b2a29371d3bfa5f04fe8cffaf329c1543
Cr-Commit-Position: refs/heads/master@{#351168}

[Evan Stade, 2015-09-25 21:13:45]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-09-25 23:14:34]

LGTM

https://codereview.chromium.org/1364913005/diff/1/components/infobars/core/si...
File components/infobars/core/simple_alert_infobar_delegate.h (right):

https://codereview.chromium.org/1364913005/diff/1/components/infobars/core/si...
components/infobars/core/simple_alert_infobar_delegate.h:23: // is shown.
Nit: Maybe this sentence should be "If |vector_icon_id| is not VECTOR_ICON_NONE,
it will be shown; otherwise, |icon_id| (if present) will be used as the icon."

https://codereview.chromium.org/1364913005/diff/1/ui/gfx/vector_icons/extensi...
File ui/gfx/vector_icons/extension_crashed.icon (right):

https://codereview.chromium.org/1364913005/diff/1/ui/gfx/vector_icons/extensi...
ui/gfx/vector_icons/extension_crashed.icon:3: // found in the LICENSE file.
We should be consistent about license headers in these.  Some icons have them,
some don't; I checked mine in recently without, given that these aren't source
code.

I think the right thing to do is remove this header from all these, but maybe we
should check with dannyb@ or some other knowledgeable person (mal? mmentovai?).

[Evan Stade, 2015-09-25 23:18:15]

https://codereview.chromium.org/1364913005/diff/1/components/infobars/core/si...
File components/infobars/core/simple_alert_infobar_delegate.h (right):

https://codereview.chromium.org/1364913005/diff/1/components/infobars/core/si...
components/infobars/core/simple_alert_infobar_delegate.h:23: // is shown.
On 2015/09/25 23:14:34, Peter Kasting wrote:
> Nit: Maybe this sentence should be "If |vector_icon_id| is not
VECTOR_ICON_NONE,
> it will be shown; otherwise, |icon_id| (if present) will be used as the icon."

ok

https://codereview.chromium.org/1364913005/diff/1/ui/gfx/vector_icons/extensi...
File ui/gfx/vector_icons/extension_crashed.icon (right):

https://codereview.chromium.org/1364913005/diff/1/ui/gfx/vector_icons/extensi...
ui/gfx/vector_icons/extension_crashed.icon:3: // found in the LICENSE file.
On 2015/09/25 23:14:34, Peter Kasting wrote:
> We should be consistent about license headers in these.  Some icons have them,
> some don't; I checked mine in recently without, given that these aren't source
> code.
> 
> I think the right thing to do is remove this header from all these, but maybe
we
> should check with dannyb@ or some other knowledgeable person (mal?
mmentovai?).

I thought I commented that you should add the header? Guess if you responded I
missed it. I already pinged the OSS gurus and yes, we need the license header.

[Peter Kasting, 2015-09-25 23:20:18]

https://codereview.chromium.org/1364913005/diff/1/ui/gfx/vector_icons/extensi...
File ui/gfx/vector_icons/extension_crashed.icon (right):

https://codereview.chromium.org/1364913005/diff/1/ui/gfx/vector_icons/extensi...
ui/gfx/vector_icons/extension_crashed.icon:3: // found in the LICENSE file.
On 2015/09/25 23:18:15, Evan Stade wrote:
> On 2015/09/25 23:14:34, Peter Kasting wrote:
> > We should be consistent about license headers in these.  Some icons have
them,
> > some don't; I checked mine in recently without, given that these aren't
source
> > code.
> > 
> > I think the right thing to do is remove this header from all these, but
maybe
> we
> > should check with dannyb@ or some other knowledgeable person (mal?
> mmentovai?).
> 
> I thought I commented that you should add the header? Guess if you responded I
> missed it. I already pinged the OSS gurus and yes, we need the license header.

OK.  Looks like mine are the only icons without this so I'll fix them.

[Evan Stade, 2015-09-28 16:34:15]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-09-28 16:34:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1364913005/#ps20001
(title: "change comment")

[commit-bot: I haz the power, 2015-09-28 16:34:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364913005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364913005/20001

[commit-bot: I haz the power, 2015-09-28 16:44:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 16:44:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2015-09-28 17:47:44]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2015-09-28 17:47:44]

+sky for owners stamp of:
    chrome/browser/plugins/plugin_observer.cc
    chrome/browser/ssl/ssl_add_certificate.cc
    ui/gfx/BUILD.gn

[Evan Stade, 2015-09-28 18:15:48]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 18:17:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364913005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364913005/40001

[commit-bot: I haz the power, 2015-09-28 18:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 18:33:16]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sky, 2015-09-28 18:59:55]

LGTM

[Evan Stade, 2015-09-28 19:09:39]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-09-28 19:09:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1364913005/#ps40001
(title: "git add")

[commit-bot: I haz the power, 2015-09-28 19:14:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364913005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364913005/40001

[Evan Stade, 2015-09-28 20:49:12]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-09-28 20:49:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1364913005/#ps60001
(title: "fix mac")

[commit-bot: I haz the power, 2015-09-28 20:52:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364913005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364913005/60001

[commit-bot: I haz the power, 2015-09-28 21:45:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-28 21:47:19]

Patchset 4 (id:??) landed as
https://crrev.com/512adb1b2a29371d3bfa5f04fe8cffaf329c1543
Cr-Commit-Position: refs/heads/master@{#351168}