Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1364863002: DocumentLoader::isCommittedButEmpty is timing-dependent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Emulate onPageFinished Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/DocumentLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 6fd8d1fa6d535b9da83ab8d1f7d3bb47fecf0b51..a98057a4637da49194007cea9199dedd19c32741 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -528,12 +528,14 @@ public class AwContents implements SmartClipProvider,
if (awWebResourceResponse != null && awWebResourceResponse.getData() == null) {
// In this case the intercepted URLRequest job will simulate an empty response
- // which doesn't trigger the onReceivedError callback. For WebViewClassic
- // compatibility we synthesize that callback. http://crbug.com/180950
+ // which doesn't trigger the onReceivedError or onPageFinished callbacks. For
+ // WebViewClassic compatibility we synthesize those callbacks.
+ // http://crbug.com/180950
mContentsClient.getCallbackHelper().postOnReceivedError(
request,
/* error description filled in by the glue layer */
new AwContentsClient.AwWebResourceError());
+ mContentsClient.getCallbackHelper().postOnPageFinished(request.url);
}
return awWebResourceResponse;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/DocumentLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698