third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp - Issue 1364863002: DocumentLoader::isCommittedButEmpty is timing-dependent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp

Issue 1364863002: DocumentLoader::isCommittedButEmpty is timing-dependent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Back to the original test fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java ('K') | « third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp b/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp

index 02c3b20c2b5974f0416c7737d613eb0c928491ee..adb96c2b70e2de1357e0012a76cea76c8e70dd29 100644

--- a/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp

+++ b/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp

@@ -2,6 +2,9 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "core/loader/DocumentLoader.h"

+#include "core/page/Page.h"

#include "platform/testing/URLTestHelpers.h"

#include "public/platform/Platform.h"

#include "public/platform/WebURLLoaderClient.h"

@@ -167,4 +170,10 @@ TEST_F(DocumentLoaderTest, MultiChunkWithReentrancy)

m_webViewHelper.reset();

}

+TEST_F(DocumentLoaderTest, isCommittedButEmpty)

+ WebViewImpl* webViewImpl = m_webViewHelper.initializeAndLoad("about:blank", true);

+ EXPECT_TRUE(toLocalFrame(webViewImpl->page()->mainFrame())->loader().documentLoader()->isCommittedButEmpty());

} // namespace blink