third_party/WebKit/Source/core/loader/DocumentLoader.cpp - Issue 1364863002: DocumentLoader::isCommittedButEmpty is timing-dependent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentLoader.cpp

Issue 1364863002: DocumentLoader::isCommittedButEmpty is timing-dependent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Back to the original test fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java ('K') | « third_party/WebKit/Source/core/loader/DocumentLoader.h ('k') | third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/DocumentLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/DocumentLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

index ba24f4d6e21fde07e25248049e60d76cc9ebd5b4..40b9779afcd1b0bda1c9930b750b5029b37aba6b 100644

--- a/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

@@ -105,6 +105,7 @@ DocumentLoader::DocumentLoader(LocalFrame* frame, const ResourceRequest& req, co

, m_request(req)

, m_isClientRedirect(false)

, m_replacesCurrentHistoryItem(false)

+ , m_dataReceived(false)

, m_navigationType(NavigationTypeOther)

, m_documentLoadTiming(*this)

, m_timeOfLastDataReceived(0.0)

@@ -482,7 +483,7 @@ void DocumentLoader::commitData(const char* bytes, size_t length)

return;

if (length)

- m_state = DataReceived;

+ m_dataReceived = true;

m_writer->addData(bytes, length);

}