android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java - Issue 1364863002: DocumentLoader::isCommittedButEmpty is timing-dependent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

Issue 1364863002: DocumentLoader::isCommittedButEmpty is timing-dependent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Back to the original test fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

index f45177f33a5415230e00562cb041362b74ce1ba5..87b50bbaf4140048674bde61e58b5e65d9c3636f 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

@@ -680,7 +680,7 @@ public class AwContentsClientShouldInterceptRequestTest extends AwTestBase {

mShouldInterceptRequestHelper.setReturnValue(new AwWebResourceResponse(null, null, null));

OnReceivedErrorHelper onReceivedErrorHelper = mContentsClient.getOnReceivedErrorHelper();

int onReceivedErrorHelperCallCount = onReceivedErrorHelper.getCallCount();

- loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), "foo://bar");

+ loadUrlSync(mAwContents, onReceivedErrorHelper, "foo://bar");

onReceivedErrorHelper.waitForCallback(onReceivedErrorHelperCallCount, 1);

gsennton 2016/07/26 15:35:19 This call is now unnecessary given that you pass o

Nate Chapin 2016/07/26 18:39:01 Done.

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/DocumentLoader.h » ('j') | no next file with comments »