Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 136483002: rebaseline blur related outputs (Closed)

Created:
6 years, 11 months ago by zheng.xu
Modified:
6 years, 11 months ago
Reviewers:
Stephen White, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

rebaseline blur related outputs rebaseline for the differences introduced by https://codereview.chromium.org/105893003/ BUG= Committed: http://code.google.com/p/skia/source/detail?r=13080

Patch Set 1 #

Patch Set 2 : cover more builders #

Total comments: 2

Patch Set 3 : revert valgrind baseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1703 lines, -364 lines) Patch
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 7 chunks +44 lines, -30 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 1 7 chunks +44 lines, -30 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 1 1 chunk +28 lines, -5 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 1 2 chunks +30 lines, -11 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 7 chunks +62 lines, -48 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 7 chunks +62 lines, -48 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 8 chunks +39 lines, -36 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 8 chunks +39 lines, -36 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 6 chunks +53 lines, -30 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 6 chunks +53 lines, -30 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 6 chunks +44 lines, -30 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 6 chunks +44 lines, -30 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 1 chunk +18 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 1 chunk +18 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 1 chunk +18 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 1 chunk +18 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 1 chunk +18 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 1 chunk +18 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 1 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 1 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 1 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 1 chunk +18 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 1 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 1 chunk +36 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 1 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 1 chunk +36 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 1 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 chunk +36 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release-NVPR/expected-results.json View 1 chunk +36 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 1 chunk +36 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 chunk +36 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 chunk +36 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Debug/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Release/expected-results.json View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zheng.xu
I I always got "HTTP Error 500: Internal Server Error", while upload new patch set ...
6 years, 11 months ago (2014-01-14 08:23:28 UTC) #1
Stephen White
Thanks for your diligence! Other than the Valgrind results (see below), LGTM. https://codereview.chromium.org/136483002/diff/20001/expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/expected-results.json File expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/expected-results.json ...
6 years, 11 months ago (2014-01-14 13:23:30 UTC) #2
zheng.xu
https://codereview.chromium.org/136483002/diff/20001/expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/expected-results.json File expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/expected-results.json (right): https://codereview.chromium.org/136483002/diff/20001/expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/expected-results.json#newcode1 expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/expected-results.json:1: { On 2014/01/14 13:23:31, Stephen White wrote: > Apparently, ...
6 years, 11 months ago (2014-01-15 02:18:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/zheng.xu@arm.com/136483002/140001
6 years, 11 months ago (2014-01-15 02:18:44 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 02:38:16 UTC) #5
Message was sent while issue was closed.
Change committed as 13080

Powered by Google App Engine
This is Rietveld 408576698