Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: minidump/minidump_thread_writer.cc

Issue 1364803004: win: Save contents of TEBs allowing !teb and !gle to work in windbg (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@dump-without-crashing
Patch Set: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « handler/win/crashy_test_program.cc ('k') | minidump/minidump_thread_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_thread_writer.cc
diff --git a/minidump/minidump_thread_writer.cc b/minidump/minidump_thread_writer.cc
index a36d76144263163a281b08acb9e276dd11f5f76c..72050bdb167575d63719a56c30a31deed483faeb 100644
--- a/minidump/minidump_thread_writer.cc
+++ b/minidump/minidump_thread_writer.cc
@@ -150,6 +150,11 @@ void MinidumpThreadListWriter::InitializeFromSnapshot(
thread->InitializeFromSnapshot(thread_snapshot, thread_id_map);
AddThread(thread.Pass());
}
+
+ // Do this in a separate loop to keep the thread stacks earlier in the dump,
+ // and together.
+ for (const ThreadSnapshot* thread_snapshot : thread_snapshots)
+ memory_list_writer_->AddFromSnapshot(thread_snapshot->ExtraMemory());
}
void MinidumpThreadListWriter::SetMemoryListWriter(
« no previous file with comments | « handler/win/crashy_test_program.cc ('k') | minidump/minidump_thread_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698