minidump/minidump_thread_writer.cc - Issue 1364803004: win: Save contents of TEBs allowing !teb and !gle to work in windbg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_thread_writer.cc

Issue 1364803004: win: Save contents of TEBs allowing !teb and !gle to work in windbg (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@dump-without-crashing

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_thread_writer.cc

diff --git a/minidump/minidump_thread_writer.cc b/minidump/minidump_thread_writer.cc

index a36d76144263163a281b08acb9e276dd11f5f76c..5503d736f66dcccb2a09aa920ae4da790d3a2060 100644

--- a/minidump/minidump_thread_writer.cc

+++ b/minidump/minidump_thread_writer.cc

@@ -150,6 +150,9 @@ void MinidumpThreadListWriter::InitializeFromSnapshot(

thread->InitializeFromSnapshot(thread_snapshot, thread_id_map);

AddThread(thread.Pass());

}

+ for (const ThreadSnapshot* thread_snapshot : thread_snapshots)

Mark Mentovai 2015/10/01 20:28:05 This does deserve a comment explaining why we’re d

scottmg 2015/10/01 21:01:07 Done.

+ memory_list_writer_->AddFromSnapshot(thread_snapshot->ExtraMemory());

}

void MinidumpThreadListWriter::SetMemoryListWriter(

« handler/win/crashy_test_program.cc ('K') | « handler/win/crashy_test_program.cc ('k') | minidump/minidump_thread_writer_test.cc » ('j') | snapshot/win/thread_snapshot_win.cc » ('J')