Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: util/win/process_structs.h

Issue 1364803004: win: Save contents of TEBs allowing !teb and !gle to work in windbg (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@dump-without-crashing
Patch Set: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« snapshot/thread_snapshot.h ('K') | « snapshot/win/thread_snapshot_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/process_structs.h
diff --git a/util/win/process_structs.h b/util/win/process_structs.h
index 79f6515259c4bb13c29564749bd329e2f3bfcf6e..f9a3a9d03ca3a8c2a329ff2aa6b631f9b7606404 100644
--- a/util/win/process_structs.h
+++ b/util/win/process_structs.h
@@ -309,12 +309,18 @@ struct CLIENT_ID {
};
// This is a partial definition of the TEB, as we do not currently use many
-// fields of it. See http://www.nirsoft.net/kernel_struct/vista/TEB.html.
+// fields of it. See http://www.nirsoft.net/kernel_struct/vista/TEB.html, and
+// the (arch-specific) definition of _TEB in winternal.h.
template <class Traits>
struct TEB {
NT_TIB<Traits> NtTib;
typename Traits::Pointer EnvironmentPointer;
CLIENT_ID<Traits> ClientId;
+ typename Traits::Pointer Reserved0[397];
Mark Mentovai 2015/09/29 22:14:04 Can you name the reserved fields to match <wintern
scottmg 2015/09/30 18:54:11 Done.
+ BYTE Reserved1[1952];
+ typename Traits::Pointer TlsSlots[64];
+ BYTE Reserved2[8];
+ typename Traits::Pointer Reserved3[32];
Mark Mentovai 2015/09/29 22:14:04 No reason you can’t have this be Reserved5/ForOle/
scottmg 2015/09/30 18:54:11 Done.
};
// See https://msdn.microsoft.com/en-us/library/gg750724.aspx.
« snapshot/thread_snapshot.h ('K') | « snapshot/win/thread_snapshot_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698