win: Save contents of TEBs allowing !teb and !gle to work in windbg

minidump/minidump_thread_writer.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 132 matching lines @@
   DCHECK_EQ(state(), kStateMutable);
   DCHECK(threads_.empty());
 
   BuildMinidumpThreadIDMap(thread_snapshots, thread_id_map);
 
   for (const ThreadSnapshot* thread_snapshot : thread_snapshots) {
     auto thread = make_scoped_ptr(new MinidumpThreadWriter());
     thread->InitializeFromSnapshot(thread_snapshot, thread_id_map);
     AddThread(thread.Pass());
   }
+
+  for (const ThreadSnapshot* thread_snapshot : thread_snapshots)

[Mark Mentovai, 2015/10/01 20:28:05]

This does deserve a comment explaining why we’re doing the same loop twice.

[scottmg, 2015/10/01 21:01:07]

Done.

+    memory_list_writer_->AddFromSnapshot(thread_snapshot->ExtraMemory());
 }
 
 void MinidumpThreadListWriter::SetMemoryListWriter(
     MinidumpMemoryListWriter* memory_list_writer) {
   DCHECK_EQ(state(), kStateMutable);
   DCHECK(threads_.empty());
 
   memory_list_writer_ = memory_list_writer;
 }
 
@@ skipping 59 matching lines @@
   }
 
   return file_writer->WriteIoVec(&iovecs);
 }
 
 MinidumpStreamType MinidumpThreadListWriter::StreamType() const {
   return kMinidumpStreamTypeThreadList;
 }
 
 }  // namespace crashpad