win: Save contents of TEBs allowing !teb and !gle to work in windbg

util/win/process_structs.h

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 291 matching lines @@
 };
 
 // See https://msdn.microsoft.com/en-us/library/gg750647.aspx.
 template <class Traits>
 struct CLIENT_ID {
   typename Traits::Pointer UniqueProcess;
   typename Traits::Pointer UniqueThread;
 };
 
 // This is a partial definition of the TEB, as we do not currently use many
-// fields of it. See http://www.nirsoft.net/kernel_struct/vista/TEB.html.
+// fields of it. See http://www.nirsoft.net/kernel_struct/vista/TEB.html, and
+// the (arch-specific) definition of _TEB in winternal.h.
 template <class Traits>
 struct TEB {
   NT_TIB<Traits> NtTib;
   typename Traits::Pointer EnvironmentPointer;
   CLIENT_ID<Traits> ClientId;
+  typename Traits::Pointer Reserved0[397];

[Mark Mentovai, 2015/09/29 22:14:04]

Can you name the reserved fields to match <winternal.h>? Start at Reserved2
(although its base offset is different, so maybe name it something like
SortaReserved2 with a comment), since you’ve got real fields where Reserved1
was.

[scottmg, 2015/09/30 18:54:11]

Done.

+  BYTE Reserved1[1952];
+  typename Traits::Pointer TlsSlots[64];
+  BYTE Reserved2[8];
+  typename Traits::Pointer Reserved3[32];

[Mark Mentovai, 2015/09/29 22:14:04]

No reason you can’t have this be Reserved5/ForOle/6/TlsExpansionSlots matching
<winternl.h> too.

Even if we’re not looking inside this structure, having things be matchy-matchy
helps reason that it is in fact equivalent to the OS’ idea of the same.

[scottmg, 2015/09/30 18:54:11]

Done.

 };
 
 // See https://msdn.microsoft.com/en-us/library/gg750724.aspx.
 template <class Traits>
 struct SYSTEM_THREAD_INFORMATION {
   union {
     struct {
       LARGE_INTEGER KernelTime;
       LARGE_INTEGER UserTime;
       LARGE_INTEGER CreateTime;
@@ skipping 115 matching lines @@
 using EXCEPTION_POINTERS64 = EXCEPTION_POINTERS<internal::Traits64>;
 
 #pragma pack(pop)
 
 //! \}
 
 }  // namespace process_types
 }  // namespace crashpad
 
 #endif  // CRASHPAD_UTIL_WIN_PROCESS_STRUCTS_H_