Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: pkg/analysis_server/test/services/refactoring/extract_method_test.dart

Issue 1364803003: Use TypeSystem in the 'Extract Method' refactoring. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/refactoring/extract_method_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/extract_method_test.dart b/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
index dfa2b237f309db3a5814538d59ecc1598fad91fa..b257699d70311939fdaf7bc6f30db03ee3d8a557 100644
--- a/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
@@ -1068,6 +1068,24 @@ main() {
expect(refactoring.returnType, 'int');
}
+ test_returnType_mixInterfaceFunction() async {
+ indexTestUnit('''
+main() {
+// start
+ if (true) {
+ return 1;
+ } else {
+ return () {};
+ }
+// end
+}
+''');
+ _createRefactoringForStartEndComments();
+ // do check
+ await refactoring.checkInitialConditions();
+ expect(refactoring.returnType, 'Object');
+ }
+
test_returnType_statements() async {
indexTestUnit('''
main() {
@@ -2581,6 +2599,35 @@ int res() {
''');
}
+ test_statements_return_multiple_interfaceFunction() {
+ indexTestUnit('''
+main(bool b) {
+// start
+ if (b) {
+ return 1;
+ }
+ return () {};
+// end
+}
+''');
+ _createRefactoringForStartEndComments();
+ // apply refactoring
+ return _assertSuccessfulRefactoring('''
+main(bool b) {
+// start
+ return res(b);
+// end
+}
+
+Object res(bool b) {
+ if (b) {
+ return 1;
+ }
+ return () {};
+}
+''');
+ }
+
test_statements_return_multiple_sameElementDifferentTypeArgs() {
indexTestUnit('''
main(bool b) {
« no previous file with comments | « pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698