Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 13648012: tcmalloc: add x32 abi support to linux_syscall_support.h (Closed)

Created:
7 years, 8 months ago by vapier
Modified:
7 years, 8 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Visibility:
Public.

Description

tcmalloc: add x32 abi support to linux_syscall_support.h These enhancements are in upstream lss project. They've been submitted to the gperftools project as well (although not yet merged). BUG=chromium:219015 TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193821

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -56 lines) Patch
M third_party/tcmalloc/chromium/src/base/linux_syscall_support.h View 8 chunks +141 lines, -56 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vapier
7 years, 8 months ago (2013-04-05 03:27:04 UTC) #1
willchan no longer on Chromium
Markus is the expert on linux_syscall_support. Markus, can you handle this review and then jar ...
7 years, 8 months ago (2013-04-05 04:11:19 UTC) #2
vapier
i've dropped the vendor/ part since upstream hasn't gotten back to me yet https://code.google.com/p/gperftools/issues/detail?id=518 as ...
7 years, 8 months ago (2013-04-10 16:24:53 UTC) #3
willchan no longer on Chromium
LGTM then
7 years, 8 months ago (2013-04-10 17:48:25 UTC) #4
vapier
for reference, those trybot failures were due to bugs on the trybots themselves CrOS was ...
7 years, 8 months ago (2013-04-11 22:16:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/13648012/4001
7 years, 8 months ago (2013-04-11 22:16:35 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-12 01:44:07 UTC) #7
Message was sent while issue was closed.
Change committed as 193821

Powered by Google App Engine
This is Rietveld 408576698