Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1364773002: [arm64] Explicit commuted conditions in unittests (Closed)

Created:
5 years, 3 months ago by Pierre Langlois
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, jbramley
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Explicit commuted conditions in unittests This patch explicitly names commuted conditions for floating point comparisons, instead of relying on CommuteFlagsCondition. Otherwise, a bug in this function would not be caught. BUG= Committed: https://crrev.com/cf38725d0b373a2610bd1f8f365035b087c7140b Cr-Commit-Position: refs/heads/master@{#30905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Pierre Langlois
5 years, 3 months ago (2015-09-23 15:28:50 UTC) #2
Benedikt Meurer
LGTM (Please don't use my private account)
5 years, 3 months ago (2015-09-24 03:47:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364773002/1
5 years, 3 months ago (2015-09-24 09:05:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 09:27:26 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 09:27:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf38725d0b373a2610bd1f8f365035b087c7140b
Cr-Commit-Position: refs/heads/master@{#30905}

Powered by Google App Engine
This is Rietveld 408576698