Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1364743002: remove unused SkCachingPixelRef (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove unused SkCachingPixelRef BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/70d58b7da535e32bcac35739d11ab8367e99f224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -184 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
D src/lazy/SkCachingPixelRef.h View 1 chunk +0 lines, -67 lines 0 comments Download
D src/lazy/SkCachingPixelRef.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 5 chunks +9 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364743002/1
5 years, 3 months ago (2015-09-23 12:35:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/70d58b7da535e32bcac35739d11ab8367e99f224
5 years, 3 months ago (2015-09-23 18:36:07 UTC) #3
hal.canary
lgtm
5 years, 3 months ago (2015-09-23 18:51:07 UTC) #5
dogben
5 years, 3 months ago (2015-09-23 18:53:13 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1359393004/ by benjaminwagner@google.com.

The reason for reverting is: Build failure:
https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubu....

Powered by Google App Engine
This is Rietveld 408576698