Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1364733002: [tools] Incrementally keep track of GC NVP output (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Incrementally keep track of GC NVP output We not keep track of the histogram as we process values and do not wait until printing the histogram. Furthermore processing the histogram is not O(n) for n values. BUG= Committed: https://crrev.com/307cc458b41c706dcf79969bb6f937f8311fb7e9 Cr-Commit-Position: refs/heads/master@{#30891}

Patch Set 1 #

Patch Set 2 : Incrementally keep track of histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M tools/eval_gc_nvp.py View 1 4 chunks +40 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Lippautz
Using this approach I could easily process the ~500MB output log.
5 years, 3 months ago (2015-09-23 13:17:33 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-09-23 13:18:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364733002/20001
5 years, 3 months ago (2015-09-23 13:29:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 13:52:41 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 13:52:57 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/307cc458b41c706dcf79969bb6f937f8311fb7e9
Cr-Commit-Position: refs/heads/master@{#30891}

Powered by Google App Engine
This is Rietveld 408576698