Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 136473017: Revert of Hook up gomadir in the GN build. (Closed)

Created:
6 years, 11 months ago by sharpaquos1974
Modified:
4 years, 4 months ago
Reviewers:
jamesr, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Hook up gomadir in the GN build. (https://codereview.chromium.org/137443024/) Reason for revert: login Original issue's description: > Hook up gomadir in the GN build. > > Without this, GYP will fail if you manually specify gomadir in your GYP_DEFINES. > > R=jamesr@chromium.org, jamesr > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245595 TBR=jamesr@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/gyp_chromium View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sharpaquos1974
Created Revert of Hook up gomadir in the GN build.
6 years, 11 months ago (2014-01-18 09:10:04 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-18 09:10:06 UTC) #2
brettw
6 years, 11 months ago (2014-01-18 17:22:58 UTC) #3
Why are you trying to revert this?

Powered by Google App Engine
This is Rietveld 408576698