Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 136473016: Add eu-strips sha1 (Closed)

Created:
6 years, 11 months ago by Ryan Tseng
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : gyp changes #

Patch Set 3 : Moved eu-strip to packaging_files_common in gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +12 lines, -0 lines 0 comments Download
A build/linux/bin/eu-strip.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/installer/linux/common/installer.include View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Tseng
6 years, 11 months ago (2014-01-18 00:31:47 UTC) #1
Ryan Tseng
Updated
6 years, 11 months ago (2014-01-18 01:17:14 UTC) #2
Paweł Hajdan Jr.
LGTM with a comment: please add a BUG= reference to explain why this is needed.
6 years, 11 months ago (2014-01-18 01:30:21 UTC) #3
iannucci
lgtm fwiw
6 years, 11 months ago (2014-01-18 01:32:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/136473016/40001
6 years, 11 months ago (2014-01-18 01:33:22 UTC) #5
Ryan Tseng
6 years, 11 months ago (2014-01-18 01:44:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r245708 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698