Ensure no changes to the JSONSerializer or PrefHashCalculator ever end up producing different hashe…

Ensure no changes to the JSONSerializer or PrefHashCalculator ever end up producing different hashes for all existing Value::Type.

The current JSON serialization used "appears" to be standard and future-proof (i.e., doesn't use pretty_print or anything silly).

However, the hashing mechanism must be strong in the face of any potential future logic changes to either JSONWriter, JSONStringValueSerializer, PrefHashCalculator. This test protects against that.

As highlighted in code comments these test hashes must never be altered to satisfy a code logic change or PrefHash* breaks.

Kept existing test hashes for list/dict values and expanded the test to all other values.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245576

[gab, 2014-01-16 23:25:15]

Bernhard, PTAL.

Cheers!
Gab

[Bernhard Bauer, 2014-01-17 12:23:04]

LGTM with nits:

https://codereview.chromium.org/136473008/diff/30001/chrome/browser/prefs/pre...
File chrome/browser/prefs/pref_hash_calculator_unittest.cc (right):

https://codereview.chromium.org/136473008/diff/30001/chrome/browser/prefs/pre...
chrome/browser/prefs/pref_hash_calculator_unittest.cc:82:
scoped_ptr<base::Value> int_value(base::Value::CreateIntegerValue(
Nit: I probably would break after int_value(.

https://codereview.chromium.org/136473008/diff/30001/chrome/browser/prefs/pre...
chrome/browser/prefs/pref_hash_calculator_unittest.cc:116: }
Nit: I don't think you need these separate scopes.

[gab, 2014-01-17 16:22:15]

Thanks, done!

https://codereview.chromium.org/136473008/diff/30001/chrome/browser/prefs/pre...
File chrome/browser/prefs/pref_hash_calculator_unittest.cc (right):

https://codereview.chromium.org/136473008/diff/30001/chrome/browser/prefs/pre...
chrome/browser/prefs/pref_hash_calculator_unittest.cc:82:
scoped_ptr<base::Value> int_value(base::Value::CreateIntegerValue(
On 2014/01/17 12:23:05, Bernhard Bauer wrote:
> Nit: I probably would break after int_value(.

Done.

https://codereview.chromium.org/136473008/diff/30001/chrome/browser/prefs/pre...
chrome/browser/prefs/pref_hash_calculator_unittest.cc:116: }
On 2014/01/17 12:23:05, Bernhard Bauer wrote:
> Nit: I don't think you need these separate scopes.

Done.

[commit-bot: I haz the power, 2014-01-17 16:23:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/136473008/130001

[commit-bot: I haz the power, 2014-01-17 19:03:26]

Change committed as 245576