Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 136473007: Mojo: Move test_embedder.* to the mojo_system_impl component. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Move test_embedder.* to the mojo_system_impl component. Also, tighten up DEPS: things outside mojo/system/ shouldn't include things in mojo/system/, unless they're an embedder in which case they can include things in mojo/system/embedder/. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M mojo/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo.gyp View 2 chunks +6 lines, -4 lines 0 comments Download
M mojo/shell/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/system/embedder/test_embedder.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 11 months ago (2014-01-16 23:00:32 UTC) #1
sky
LGTM
6 years, 11 months ago (2014-01-16 23:10:40 UTC) #2
viettrungluu
6 years, 11 months ago (2014-01-16 23:51:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r245381 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698