Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 136473006: [GCM] Add valgrind support for running gcm tests (Closed)

Created:
6 years, 11 months ago by Nicolas Zea
Modified:
6 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

[GCM] Add valgrind support for running gcm tests BUG=284553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/valgrind/chrome_tests.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nicolas Zea
PTAL
6 years, 11 months ago (2014-01-16 22:30:54 UTC) #1
Lei Zhang
lgtm Are you going to get this on to the bots as well?
6 years, 11 months ago (2014-01-16 22:37:27 UTC) #2
Nicolas Zea
On 2014/01/16 22:37:27, Lei Zhang wrote: > lgtm > > Are you going to get ...
6 years, 11 months ago (2014-01-16 22:42:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/136473006/1
6 years, 11 months ago (2014-01-16 22:44:45 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 00:54:49 UTC) #5
Message was sent while issue was closed. 
Change committed as 245398

Powered by Google App Engine
This is Rietveld 408576698