Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 136473004: Move kExtensionProcess to src/extensions/common/switches.cc (Closed)

Created:
6 years, 11 months ago by James Cook
Modified:
6 years, 11 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move kExtensionProcess to src/extensions/common/switches.cc app_shell needs it and it should be in the src/extensions module anyhow. BUG=none TEST=compiles TBR=miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245380

Patch Set 1 #

Patch Set 2 : fix app_shell (switches) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M apps/shell/shell_content_browser_client.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/switches.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/136473004/1
6 years, 11 months ago (2014-01-16 19:02:11 UTC) #1
James Cook
Note to self: Land this after https://codereview.chromium.org/136453005/
6 years, 11 months ago (2014-01-16 19:07:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/136473004/90001
6 years, 11 months ago (2014-01-16 21:56:14 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 23:50:50 UTC) #4
Message was sent while issue was closed.
Change committed as 245380

Powered by Google App Engine
This is Rietveld 408576698