Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1364693002: [heap] Turn on parallel compaction (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Turn on parallel compaction R=hpayer@chromium.org BUG=chromium:524425 LOG=N Committed: https://crrev.com/04db5bfa915766b228218ddc748af308b57ae8ea Cr-Commit-Position: refs/heads/master@{#31763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (11 generated)
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-09-23 07:56:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364693002/1
5 years, 3 months ago (2015-09-23 07:58:58 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-23 08:26:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364693002/1
5 years, 3 months ago (2015-09-23 13:19:32 UTC) #7
Michael Achenbach
Unchecked - due to other revert...
5 years, 3 months ago (2015-09-23 13:49:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364693002/1
5 years, 1 month ago (2015-11-02 18:00:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/9633)
5 years, 1 month ago (2015-11-02 18:15:01 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364693002/1
5 years, 1 month ago (2015-11-03 00:10:37 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 00:28:21 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364693002/1
5 years, 1 month ago (2015-11-03 21:46:23 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 22:03:43 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364693002/1
5 years, 1 month ago (2015-11-03 22:13:23 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 22:14:53 UTC) #24
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/04db5bfa915766b228218ddc748af308b57ae8ea Cr-Commit-Position: refs/heads/master@{#31763}
5 years, 1 month ago (2015-11-03 22:15:06 UTC) #25
Michael Lippautz
5 years, 1 month ago (2015-11-03 23:24:04 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1424313008/ by mlippautz@chromium.org.

The reason for reverting is: Fails on gc stress
 
https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20s....

Powered by Google App Engine
This is Rietveld 408576698