Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1364683003: Range.intersectsNode() does not behave according to the specification. (Closed)

Created:
5 years, 3 months ago by pals
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Range.intersectsNode() does not behave according to the specification. We should return true if parent is null as per specification. https://dom.spec.whatwg.org/#dom-range-intersectsnode Previously, WebKit would throw a NotFoundError, apparently to match Firefox's behavior. However, these days, Firefox complies with the specification and returns true here. Picked from webkit https://trac.webkit.org/changeset/189225 BUG=535153 Committed: https://crrev.com/7634f50b38265607d2304c785dd07366e0a09585 Cr-Commit-Position: refs/heads/master@{#352310}

Patch Set 1 #

Patch Set 2 : Test rebaselined #

Total comments: 4

Patch Set 3 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Range/range-intersectsNode-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Range/resources/intersectsNode.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 1 2 2 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
pals
PTAL. Thanks
5 years, 3 months ago (2015-09-23 11:30:44 UTC) #3
sof
Could you create a tracking bug for this, as it makes a user facing change ...
5 years, 3 months ago (2015-09-23 12:16:46 UTC) #5
pals
On 2015/09/23 12:16:46, sof wrote: > Could you create a tracking bug for this, as ...
5 years, 3 months ago (2015-09-23 12:38:27 UTC) #6
sof
On 2015/09/23 12:38:27, pals wrote: > On 2015/09/23 12:16:46, sof wrote: > > Could you ...
5 years, 2 months ago (2015-09-25 09:16:47 UTC) #7
sof
https://codereview.chromium.org/1364683003/diff/40001/Source/core/dom/Range.cpp File Source/core/dom/Range.cpp (right): https://codereview.chromium.org/1364683003/diff/40001/Source/core/dom/Range.cpp#newcode402 Source/core/dom/Range.cpp:402: if (!parentNode) Could you move this up to the ...
5 years, 2 months ago (2015-09-25 09:17:04 UTC) #8
sof
On 2015/09/25 09:16:47, sof wrote: > On 2015/09/23 12:38:27, pals wrote: > > On 2015/09/23 ...
5 years, 2 months ago (2015-09-25 09:25:35 UTC) #9
pals
Fixed the comments. PTAL. https://codereview.chromium.org/1364683003/diff/40001/Source/core/dom/Range.cpp File Source/core/dom/Range.cpp (right): https://codereview.chromium.org/1364683003/diff/40001/Source/core/dom/Range.cpp#newcode402 Source/core/dom/Range.cpp:402: if (!parentNode) On 2015/09/25 09:17:04, ...
5 years, 2 months ago (2015-09-28 11:29:06 UTC) #10
sof
lgtm. Could you add a mention of https://trac.webkit.org/changeset/189225 to the description also?
5 years, 2 months ago (2015-09-28 14:08:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364683003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364683003/60001
5 years, 2 months ago (2015-10-05 07:19:06 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 2 months ago (2015-10-05 09:40:15 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 09:41:21 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7634f50b38265607d2304c785dd07366e0a09585
Cr-Commit-Position: refs/heads/master@{#352310}

Powered by Google App Engine
This is Rietveld 408576698