Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1364673002: RenderViewTests: Unsuppress even more LSAN leaks since we fixed the GC. (Closed)

Created:
5 years, 3 months ago by loyso (OOO)
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RenderViewTests: Unsuppress even more LSAN leaks since we fixed the GC. Let's gather the benefits of this fix: https://codereview.chromium.org/1363523002/ BUG=506433 BUG=328552 BUG=484760 BUG=356785 BUG=431213 BUG=416665 Committed: https://crrev.com/7d4047d17d21b2fda3ae15a7aa1e3a9c0d06f533 Cr-Commit-Position: refs/heads/master@{#350335}

Patch Set 1 #

Patch Set 2 : Revert object_template_builder suppression to experiment. #

Patch Set 3 : Suppress object_template_builder. Looks like it is a real leak. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M build/sanitizers/lsan_suppressions.cc View 1 2 1 chunk +1 line, -19 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
loyso (OOO)
5 years, 3 months ago (2015-09-23 07:36:20 UTC) #2
haraken
non-owner LGTM
5 years, 3 months ago (2015-09-23 07:38:27 UTC) #3
loyso (OOO)
I'm going to have a look at 431213 and 416665 tomorrow (APAC). Would like to ...
5 years, 3 months ago (2015-09-23 07:39:26 UTC) #4
Alexander Potapenko
On 2015/09/23 07:39:26, loyso wrote: > I'm going to have a look at 431213 and ...
5 years, 3 months ago (2015-09-23 09:58:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364673002/40001
5 years, 3 months ago (2015-09-23 10:28:14 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-23 18:15:56 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 18:35:32 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7d4047d17d21b2fda3ae15a7aa1e3a9c0d06f533
Cr-Commit-Position: refs/heads/master@{#350335}

Powered by Google App Engine
This is Rietveld 408576698