Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: PRESUBMIT.py

Issue 1364643002: Remove unused function in presubmit script (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove unused FilterFiles function Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api)) 226 _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api))
227 results.extend( 227 results.extend(
228 _CheckNoInlineHeaderIncludesInNormalHeaders(input_api, output_api)) 228 _CheckNoInlineHeaderIncludesInNormalHeaders(input_api, output_api))
229 return results 229 return results
230 230
231 231
232 def _SkipTreeCheck(input_api, output_api): 232 def _SkipTreeCheck(input_api, output_api):
233 """Check the env var whether we want to skip tree check. 233 """Check the env var whether we want to skip tree check.
234 Only skip if include/v8-version.h has been updated.""" 234 Only skip if include/v8-version.h has been updated."""
235 src_version = 'include/v8-version.h' 235 src_version = 'include/v8-version.h'
236 FilterFile = lambda file: file.LocalPath() == src_version
237 if not input_api.AffectedSourceFiles( 236 if not input_api.AffectedSourceFiles(
238 lambda file: file.LocalPath() == src_version): 237 lambda file: file.LocalPath() == src_version):
239 return False 238 return False
240 return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip' 239 return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip'
241 240
242 241
243 def _CheckChangeLogFlag(input_api, output_api, warn): 242 def _CheckChangeLogFlag(input_api, output_api, warn):
244 """Checks usage of LOG= flag in the commit message.""" 243 """Checks usage of LOG= flag in the commit message."""
245 results = [] 244 results = []
246 if (input_api.change.BUG and input_api.change.BUG != 'none' and 245 if (input_api.change.BUG and input_api.change.BUG != 'none' and
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 'v8_win64_rel': set(['defaulttests']), 290 'v8_win64_rel': set(['defaulttests']),
292 'v8_mac_rel': set(['defaulttests']), 291 'v8_mac_rel': set(['defaulttests']),
293 'v8_linux_arm_rel': set(['defaulttests']), 292 'v8_linux_arm_rel': set(['defaulttests']),
294 'v8_linux_arm64_rel': set(['defaulttests']), 293 'v8_linux_arm64_rel': set(['defaulttests']),
295 'v8_linux_mipsel_compile_rel': set(['defaulttests']), 294 'v8_linux_mipsel_compile_rel': set(['defaulttests']),
296 'v8_linux_mips64el_compile_rel': set(['defaulttests']), 295 'v8_linux_mips64el_compile_rel': set(['defaulttests']),
297 'v8_android_arm_compile_rel': set(['defaulttests']), 296 'v8_android_arm_compile_rel': set(['defaulttests']),
298 'v8_linux_chromium_gn_rel': set(['defaulttests']), 297 'v8_linux_chromium_gn_rel': set(['defaulttests']),
299 }, 298 },
300 } 299 }
OLDNEW
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698