Issue 136463004: Fix NetworkSMSHandler to use DBus service name instead of connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136463004: Fix NetworkSMSHandler to use DBus service name instead of connection. (Closed)

Created:
6 years, 11 months ago by Ben Chan

Modified:
6 years, 10 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix NetworkSMSHandler to use DBus service name instead of connection. The 'DBus.Connection' property of a shill cellular device object is deprecated. This CL fixes NetworkSMSHandler to use the DBus service name, obtained from the 'DBus.Service' property of a shill cellular device object, to create a DBus object proxy that interacts with a modem object managed by cromo or ModemManager. BUG=334337 TEST=Tested the following: 1. Run chromeos_unittests. 2. Send a SMS to a E936 modem, which is managed by cromo, and verify that Chrome pops up a notification of the received SMS. 3. Repeat (2) using a MU736 modem, which is managed by ModemManager. 4. Repeat (2) using a pseudomodem. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245080

Patch Set 1 : #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -33 lines)			Patch
M	chromeos/dbus/fake_modem_messaging_client.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/dbus/fake_shill_device_client.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chromeos/network/network_sms_handler.cc	View		14 chunks	+27 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/136463004/70001

6 years, 11 months ago (2014-01-15 05:53:17 UTC) #3

Message was sent while issue was closed.

Change committed as 245080

Expand Messages | Collapse Messages