LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html - Issue 136463002: Don't fire popstate event on initial document load

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html

Issue 136463002: Don't fire popstate event on initial document load (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/loader/stateobjects/resources/pushstate-in-iframe-child.html ('k') | LayoutTests/http/tests/history/popstate-fires-with-pending-requests.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <script>	1 <script>

2 onunload = function() {	2 window.onload = function() {

	3 top.opener.windowLoaded();
	Jens Widell 2014/01/16 08:16:20 Since the window is navigated to a different top-l Since the window is navigated to a different top-level document and back, this onload handler is called twice, and thus incorrectly "starts" the test again in the middle. Should have copied the "sessionStorage.beganTest" mechanism from the old onpopstate instead of just this call. This test case bug appears to be involved in the Windows-only crash found by the trybots, but doesn't (of course) explain why we'd crash.
	4 }

	5

	6 window.onunload = function() {

3 // No page cache	7 // No page cache

4 }	8 }

5	9

6 onpopstate = function(e) {	10 window.onpopstate = function(e) {

7 if (!sessionStorage.beganTest) {

8 sessionStorage.beganTest = true;

9 top.opener.windowLoaded();

10 return;

11 }

12

13 alert("onpopstate");	11 alert("onpopstate");

14 top.opener.notifyDone(window == parent ? "FAIL" : "PASS");	12 top.opener.notifyDone(window == parent ? "FAIL" : "PASS");

15 }	13 }

16 </script>	14 </script>

OLD	NEW