Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 13646006: Remove the ENABLE_IFRAME_SEAMLESS compile-time flag. (Closed)

Created:
7 years, 8 months ago by Mike West
Modified:
7 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, Alexis Menard
Visibility:
Public.

Description

Remove the ENABLE_IFRAME_SEAMLESS compile-time flag. This patch drops the ~10 instances of '#IFDEF ENABLE(IFRAME_SEAMLESS)' from the codebase. It shouldn't effect any web-visible behavior, as the interesting bits are all hidden safely behind a runtime flag, whose behavior is untouched by this patch. The only non-mechanical change in this patch is the addition of an annotation to the iframe@seamless attribute, ensuring that it's only exposed if the runtime flag is set (that was an oversight in the original code). R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147704

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebaseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -41 lines) Patch
M Source/WTF/wtf/FeatureDefines.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/css/CSSSelector.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/css/CSSSelector.cpp View 1 4 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/css/SelectorChecker.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/css/html.css View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/html/HTMLIFrameElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/features.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M Tools/Scripts/webkitperl/FeatureList.pm View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike West
Hi Eric! Would you mind taking a look at this IFDEF-killing patch? Thanks! -mike
7 years, 8 months ago (2013-04-05 11:59:56 UTC) #1
eseidel
LGTM. We may need to patch M27 to not expose seamless if the property is ...
7 years, 8 months ago (2013-04-05 19:39:45 UTC) #2
Mike West
On 2013/04/05 19:39:45, Eric Seidel (Google) wrote: > LGTM. We may need to patch M27 ...
7 years, 8 months ago (2013-04-05 20:12:35 UTC) #3
Mike West
7 years, 8 months ago (2013-04-05 23:32:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r147704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698