Refactor android_webview_shell and its tests

android_webview/android_webview_shell.gyp

Index: android_webview/android_webview_shell.gyp
diff --git a/android_webview/android_webview_shell.gyp b/android_webview/android_webview_shell.gyp
index a5d898f94f9961e6143ee2be917c2132aff3c538..b7be21e1aad1955117e47ffeecb3076a4c4b5d52 100644
--- a/android_webview/android_webview_shell.gyp
+++ b/android_webview/android_webview_shell.gyp
@@ -6,22 +6,69 @@
     {
       'target_name': 'android_webview_shell_apk',

[Yoland Yan(Google), 2015/09/23 19:51:51]

should the name also change to system_webview_shell_apk?

       'type': 'none',
+      'variables': {
+        'apk_name': 'AndroidWebViewShell',

[Yoland Yan(Google), 2015/09/23 19:51:51]

ditto

+        'java_in_dir': 'tools/system_webview_shell/apk',
+        'resource_dir': 'tools/system_webview_shell/apk/res',
+        'android_manifest_path': 'tools/system_webview_shell/apk/AndroidManifest.xml', # for lint
+      },
+      'includes': [
+        '../build/java_apk.gypi',
+      ],
+    },
+    {
+      # android_webview_apk creates a .jar as a side effect. Any java
+      # targets that need that .jar in their classpath should depend on this
+      # target. For more details see the content_shell_apk_java target.
+      'target_name': 'android_webview_shell_apk_java',

[Yoland Yan(Google), 2015/09/23 19:51:51]

ditto

+      'type': 'none',
+      'dependencies': [
+        'android_webview_shell_apk',
+      ],
+      'includes': [ '../build/apk_fake_jar.gypi' ],
+    },
+    {
+      'target_name': 'android_webview_shell_page_cycler_apk',

[Yoland Yan(Google), 2015/09/23 19:51:51]

ditto

+      'type': 'none',
       'dependencies': [
         '../base/base.gyp:base_java_test_support',
+        '../testing/android/on_device_instrumentation.gyp:broker_java',
+        '../testing/android/on_device_instrumentation.gyp:require_driver_apk',
+        'android_webview_shell_apk_java',
       ],
       'variables': {
-        'apk_name': 'AndroidWebViewShell',
-        'java_in_dir': 'tools/WebViewShell',
-        'resource_dir': 'tools/WebViewShell/res',
+        'apk_name': 'AndroidWebViewShellPageCycler',

[Yoland Yan(Google), 2015/09/23 19:51:51]

ditto

+        'java_in_dir': '../android_webview/tools/system_webview_shell/page_cycler',
         'is_test_apk': 1,
         'test_type': 'instrumentation',
-        'isolate_file': 'android_webview_shell_test_apk.isolate',
-        'android_manifest_path': 'tools/WebViewShell/AndroidManifest.xml', # for lint
+        'android_manifest_path': 'tools/system_webview_shell/page_cycler/AndroidManifest.xml',
       },
       'includes': [
         '../build/java_apk.gypi',
         '../build/android/test_runner.gypi',
       ],
     },
+    {
+      'target_name': 'android_webview_shell_layout_test_apk',

[Yoland Yan(Google), 2015/09/23 19:51:51]

ditto

+      'type': 'none',
+      'dependencies': [
+        '../base/base.gyp:base_java_test_support',
+        '../testing/android/on_device_instrumentation.gyp:broker_java',
+        '../testing/android/on_device_instrumentation.gyp:require_driver_apk',
+        'android_webview_shell_apk_java',
+      ],
+      'variables': {
+        'apk_name': 'AndroidWebViewShellLayoutTest',

[Yoland Yan(Google), 2015/09/23 19:51:51]

ditto

+        'java_in_dir': '../android_webview/tools/system_webview_shell/layout_tests',
+        'is_test_apk': 1,
+        'test_type': 'instrumentation',
+        'isolate_file': 'android_webview_shell_test_apk.isolate',
+        'android_manifest_path': 'tools/system_webview_shell/layout_tests/AndroidManifest.xml',
+      },
+      'includes': [
+        '../build/java_apk.gypi',
+        '../build/android/test_runner.gypi',
+      ]
+    },
   ],
 }