Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1364583004: [intl] remove flag expecting collator/default-locale test to fail (Closed)

Created:
5 years, 2 months ago by caitp (gmail)
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove FAIL expectation for intl/collator/default-locale on Android and Mac BUG=v8:2899 LOG=N R= Committed: https://crrev.com/7b405200b0f337f4fd9c216c71433e4738756a53 Cr-Commit-Position: refs/heads/master@{#30979}

Patch Set 1 : Remove Mac flag, works locally #

Patch Set 2 : Remove Android flag too, for try-run #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M test/intl/intl.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
caitp (gmail)
Remove some test failures, make the test run more smooth on mac (and maybe android, ...
5 years, 2 months ago (2015-09-25 15:35:00 UTC) #1
caitp (gmail)
+svenpanne / +jkummerow who may have been responsible for pulling in a version of ICU ...
5 years, 2 months ago (2015-09-28 07:58:11 UTC) #3
Jakob Kummerow
I think ICU is rolled automatically. There are no try bots for tests on Android. ...
5 years, 2 months ago (2015-09-28 14:27:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364583004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364583004/20001
5 years, 2 months ago (2015-09-28 14:29:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 14:51:49 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 14:52:05 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b405200b0f337f4fd9c216c71433e4738756a53
Cr-Commit-Position: refs/heads/master@{#30979}

Powered by Google App Engine
This is Rietveld 408576698