app_shell: Make renderer run background page JavaScript

chrome/browser/extensions/extension_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_host.h"
 
 #include <list>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 12 matching lines @@
 #include "chrome/browser/media/media_capture_devices_dispatcher.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/notification_service.h"
+#include "content/public/browser/notification_source.h"
+#include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_error.h"
 #include "extensions/browser/extensions_browser_client.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/browser/view_type_utils.h"
@@ skipping 141 matching lines @@
     // synchronously. The process creation is the real meaty part that we want
     // to defer.
     CreateRenderViewNow();
   } else {
     ProcessCreationQueue::GetInstance()->CreateSoon(this);
   }
 }
 
 void ExtensionHost::CreateRenderViewNow() {
   LoadInitialURL();
-  if (IsBackgroundPage()) {
+  if (!IsBackgroundPage()) {

[kirr, 2014/03/07 12:23:40]

Is it a misprint in condition? Seems like DidCreateRenderViewForBackgroundPage
is only for background pages.

[James Cook, 2014/03/07 17:14:47]

Yeah, that looks wrong. I'm taking a closer look at the code now.  Is there a
bug you think is caused by this problem?

     DCHECK(IsRenderViewLive());
-    ExtensionSystem::GetForBrowserContext(browser_context_)->
-        extension_service()->DidCreateRenderViewForBackgroundPage(this);
+    ExtensionService* service = GetExtensionService();
+    if (service)
+      service->DidCreateRenderViewForBackgroundPage(this);
   }
 }
 
+ExtensionService* ExtensionHost::GetExtensionService() {
+  return ExtensionSystem::GetForBrowserContext(browser_context_)
+      ->extension_service();
+}
+
 const GURL& ExtensionHost::GetURL() const {
   return host_contents()->GetURL();
 }
 
 void ExtensionHost::LoadInitialURL() {
   host_contents_->GetController().LoadURL(
       initial_url_, content::Referrer(), content::PAGE_TRANSITION_LINK,
       std::string());
 }
 
@@ skipping 97 matching lines @@
   // If the document has already been marked as available for this host, then
   // bail. No need for the redundant setup. http://crbug.com/31170
   if (document_element_available_)
     return;
   document_element_available_ = true;
   OnDocumentAvailable();
 }
 
 void ExtensionHost::OnDocumentAvailable() {
   DCHECK(extension_host_type_ == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE);
-  ExtensionSystem::GetForBrowserContext(browser_context_)->
-      extension_service()->SetBackgroundPageReady(extension_);
+  ExtensionService* service = GetExtensionService();
+  if (service)
+    service->SetBackgroundPageReady(extension_);
+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_EXTENSION_BACKGROUND_PAGE_READY,
+      content::Source<const Extension>(extension_),
+      content::NotificationService::NoDetails());
 }
 
 void ExtensionHost::CloseContents(WebContents* contents) {
   Close();
 }
 
 bool ExtensionHost::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(ExtensionHost, message)
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_Request, OnRequest)
@@ skipping 127 matching lines @@
 
 void ExtensionHost::RequestMediaAccessPermission(
     content::WebContents* web_contents,
     const content::MediaStreamRequest& request,
     const content::MediaResponseCallback& callback) {
   MediaCaptureDevicesDispatcher::GetInstance()->ProcessMediaAccessRequest(
       web_contents, request, callback, extension());
 }
 
 }  // namespace extensions