Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1364473005: Put back code that was incorrectly removed in r342867. (Closed)

Created:
5 years, 2 months ago by Roger Tawa OOO till Jul 10th
Modified:
5 years, 2 months ago
Reviewers:
achuithb
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put back code that was incorrectly removed in r342867. While testing I found that CL https://codereview.chromium.org/1243213002/ broke saving passwords on desktop. This might also explain crbug.com/533401 BUG=520469, 533401 Committed: https://crrev.com/a92b4ab508925a596f31cbf60d4b3cc5b392925d Cr-Commit-Position: refs/heads/master@{#350420}

Patch Set 1 #

Patch Set 2 : Fix desktop bug intro'ed by 1243213002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/resources/gaia_auth_host/authenticator.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Roger Tawa OOO till Jul 10th
Hi Achuith, Please take a look. Thanks,
5 years, 2 months ago (2015-09-23 18:04:02 UTC) #2
achuithb
lgtm. This should have browser test coverage.
5 years, 2 months ago (2015-09-23 18:26:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364473005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364473005/20001
5 years, 2 months ago (2015-09-23 18:43:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/111149)
5 years, 2 months ago (2015-09-23 19:03:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364473005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364473005/20001
5 years, 2 months ago (2015-09-23 20:57:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/111301)
5 years, 2 months ago (2015-09-23 21:53:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364473005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364473005/20001
5 years, 2 months ago (2015-09-23 23:56:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-24 00:49:53 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-24 00:51:40 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a92b4ab508925a596f31cbf60d4b3cc5b392925d
Cr-Commit-Position: refs/heads/master@{#350420}

Powered by Google App Engine
This is Rietveld 408576698